Open
Conversation
2ffbbc8 to
6edc3a1
Compare
kflemin
approved these changes
Jan 27, 2025
kflemin
requested changes
Jan 27, 2025
Contributor
There was a problem hiding this comment.
@perryr16 This is almost working!
- I've noticed that nothing happens with the labels if we are importing data into a cycle that already has data in it (performing a merge). No new labels are created, and the property labels are not added to the properties. Doesn't matter if the existing property had a label already or didn't. It does work as designed in an empty cycle though.
- When creating a new label via import (and really any time), can you make the default be "show in list = true" instead of false? It's confusing otherwise.
- Can you also remove the first line of the csv inventory export that lists some information about filters? It breaks the subsequent CSV import and is not comprehensive anyway. I think just listing the headers directly will be better.
Contributor
Author
|
Most recent commits address the following
Outstanding issue / edge case
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
What's this PR do?
Allows users to upload property and taxlot labels. Incoming values in a csv's "Property Labels" or "Tax Lot Labels" column will be processed and applied as a label. If a label does not exist, one will be created.
Labels are applied to a
PropertyView, however during the upload processPropertyStatesare created (mapping) several steps before aPropertyViewis applied (matching). As a result, thePropertyStatehas to carry the incoming label information in a new text fieldPropertyState.incoming_labelsuntil it can be applied to the relatedPropertyView.How should this be manually tested?
From the inventory list, export a set of properties to a csv or spreadsheet. Then in a new cycle, upload that exported file, confirm the correct labels are applied.
What are the relevant tickets?
#4789
Screenshots (if appropriate)