Skip to content

DDS-3046 - reduce logging level when validating user certificates#62

Open
Johxzu wants to merge 2 commits intoSK-EID:masterfrom
Johxzu:feature/DDS-3046
Open

DDS-3046 - reduce logging level when validating user certificates#62
Johxzu wants to merge 2 commits intoSK-EID:masterfrom
Johxzu:feature/DDS-3046

Conversation

@Johxzu
Copy link
Copy Markdown

@Johxzu Johxzu commented Feb 19, 2026

task: https://jira.sk.ee/browse/DDS-3046

commenting on pom.xml change:

  • Project uses org.slf4j:slf4j-api:1.7.36 (pom.xml:99).
  • ch.qos.logback:logback-classic:1.3.12 (pom.xml before change) targets SLF4J 2.x and references org.slf4j.spi.LoggingEventAware.
  • That class does not exist in SLF4J 1.7.x, causing:
    • java: cannot access org.slf4j.spi.LoggingEventAware.

So changed Logback to 1.2.13 (pom.xml:132), which is compatible with SLF4J 1.7.x and lets logging-capture tests compile/run.

Alternative would be a broader upgrade to SLF4J 2.x across the project, but that’s a larger migration.

@kaidohallik kaidohallik self-requested a review March 31, 2026 08:52
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kuna ch.qos.logback:logback-classic versioonile 1.2.13 raporteeritakse https://mvnrepository.com/artifact/ch.qos.logback/logback-classic/1.2.13 põhjal 12 CVE, muuhulgas kriitilisi, siis otsustati antud testi selle PR raames mitte lisada, kas saaksid selle faili muudatused tagasi tõmmata.

Selle testi saab lisada peale SLF4J API versioonile 2 üleminekut.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kas saaksid muuta 2019 --> 2026, sest hetkel kehtiv põhimõte on uuendada muudetud failide litsentsi päistes aastat.

pom.xml Outdated
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.3.12</version>
<version>1.2.13</version>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kas saaksid selle muudatuse tagasi tõmmata, kuna versioon 1.2.13 sisaldab kriitilisi haavatavusi ja otsustati testi antud PR raames mitte lisada.

@kaidohallik
Copy link
Copy Markdown
Collaborator

Reverted logback downgrade and removed test.
Tested manually with mid-rest-java-demo with PR SK-EID/mid-rest-java-demo#9 changes and confirm that this log is now available in DEBUG level.

@kaidohallik kaidohallik self-requested a review April 8, 2026 10:20
@umuser umuser self-requested a review April 9, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants