Fixed memory leak in UDPForwarder.cpp #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g assigned to when creating UDPForwarder (using IPv6) but not being freed after use
exuvo
added a commit
to exuvo/SLikeNet
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leak is caused by addrinfo struct being assigned to when creating UDPForwarder (using IPv6) but not being freed after use.
Leak is relatively slow and can take a while to grow but when dealing with large traffic it is definitely noticeable. Leak was originally found within the original RakNet code base and still exists here so I thought I would submit the fix that I used that resolves the leak.