nearly match CocoNutBall#1895
Merged
ThatNintendoNerd merged 10 commits intoSMGCommunity:masterfrom Mar 3, 2026
Merged
Conversation
Report for RMGK01 (b928703 - 1fcdc89)📈 Matched code: 46.35% (+0.08%, +4372 bytes) ✅ 37 new matches
...and 7 more new matches 📈 9 improvements in unmatched items
|
ThatNintendoNerd
requested changes
Feb 16, 2026
Collaborator
ThatNintendoNerd
left a comment
ThatNintendoNerd
left a comment
There was a problem hiding this comment.
Please run clang-format on your changes.
src/Game/Enemy/CocoNutBall.cpp
Outdated
| } | ||
|
|
||
| TRot3f rotate; | ||
| f32 angle = 0.017453292f * f2; |
Collaborator
There was a problem hiding this comment.
Use PI_180 from math_types.hpp instead of a magic number.
include/Game/Enemy/CocoNutBall.hpp
Outdated
| @@ -0,0 +1,54 @@ | |||
| #include "Game/LiveActor/LiveActor.hpp" | |||
| #include "Game/Util/JMapInfo.hpp" | |||
Collaborator
There was a problem hiding this comment.
LiveActor.hpp includes NameObj.hpp which already includes JMapInfo.hpp, so this include statement is unnecessary.
Contributor
Author
|
requested changes should have been adressed |
Frityet
pushed a commit
to Frityet/Petari
that referenced
this pull request
Mar 12, 2026
* update CocoNutBall splits * match 97% of CocoNutBall.cpp * fix regressions * clean up includes and use math constant * removed too many includes * improve formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.