Skip to content

Conversation

@Yeonghunj
Copy link

πŸ’Ž 과제 κ΅¬ν˜„ μ„€λͺ…

과제λ₯Ό μœ„ν•΄ μ‚¬μš©ν–ˆλ˜ ν•¨μˆ˜, μˆ˜μ •ν•œ 파일 λ“± κ΅¬ν˜„ λ‚΄μš©μ— λŒ€ν•œ κ°„λ‹¨ν•œ μ„€λͺ…을 μž‘μ„±ν•΄ μ£Όμ„Έμš”.

🏁 PR 체크리슀트

  • [ o] μ½”λ“œκ°€ 였λ₯˜ 없이 μ •μƒμ μœΌλ‘œ μ‹€ν–‰λ˜λ‚˜μš”?
  • [ o] 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜(ν…œν”Œλ¦Ώ ν™œμš©)을 μ€€μˆ˜ν–ˆλ‚˜μš”?
  • [ o] 과제 λ§ˆκ°κΈ°ν•œμ„ μ€€μˆ˜ν–ˆλ‚˜μš”?

πŸ–ΌοΈ Screenshot / Video

πŸ™Œ Issue

과제 μˆ˜ν–‰ 쀑 μ–΄λ €μ› λ˜ λΆ€λΆ„μ΄λ‚˜ κΆκΈˆν–ˆλ˜ 점을 자유둭게 μž‘μ„±ν•΄ μ£Όμ„Έμš”.

@Yeonghunj Yeonghunj self-assigned this Apr 8, 2024
Copy link

@hoooooojjjj hoooooojjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅³κ΅³ μž˜ν–ˆμŠ΅λ‹ˆλ‹€~

Copy link
Contributor

@cheeze-hyeon cheeze-hyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! κ³Όμ œν•˜λŠλΌ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€! 😸 그런데 μ§€κΈˆ main <- yeonghun-week5-hw 둜 PR νƒ€κ²Ÿμ΄ μ„€μ •λ˜μ–΄ μžˆλŠ”λ° **yeonghun-week5** <- yeonghun-week5-hw 둜 λ°”κΎΈκ³  merge ν•΄μ£Όμ…”μ•Ό ν•΄μš”!!

Comment on lines +52 to +59
key={comment.id}
id={comment.id}
content={comment.content}
createdAt={comment.created_at}
postId={comment.post}
author={comment.author}
handleCommentDelete={handleCommentDelete}
handleCommentEdit={handleCommentEdit}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key={comment.id}
id={comment.id}
content={comment.content}
createdAt={comment.created_at}
postId={comment.post}
author={comment.author}
handleCommentDelete={handleCommentDelete}
handleCommentEdit={handleCommentEdit}
comment={comment}
handleCommentDelete={handleCommentDelete}
handleCommentEdit={handleCommentEdit}

μž‘μ„±ν•΄μ€€ λ°©μ‹μœΌλ‘œ propsλ₯Ό λ„˜κ²¨μ€„ μˆ˜λ„ μžˆμ§€λ§Œ comment 객체λ₯Ό λ„˜κ²¨μ£ΌλŠ” 건 μ–΄λ–¨κΉŒμš”? 일일이 propsλ₯Ό 적기에도 번거둭고 CommentElementμ—μ„œ μ§€κΈˆ λͺ¨λ“  propsλ₯Ό ν™œμš©ν•˜κ³  μžˆμ§€ μ•ŠμœΌλ‹ˆκΉŒ comment 자체λ₯Ό λ„˜κ²¨μ£Όκ³  CommentElementμ—μ„œ ν•„μš”ν•œ λ‚΄μš©μ„ λ””μŠ€νŠΈλŸ­μ²˜λ§ ν• λ‹ΉμœΌλ‘œ ν™œμš©ν•˜λŠ” 것도 쒋을 것 κ°™μ•„μš”!

@@ -1,21 +1,39 @@
import { useState, useEffect } from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

과제 PRμ—λŠ” 과제 λ‚΄μš©λ§Œ 담기도둝 ν•΄μ£Όμ„Έμš”! μ„Έλ―Έλ‚˜μ—μ„œ ν–ˆλ˜ μ½”λ“œ μž‘μ„± λ‚΄μš©μ€ 이름 λΈŒλžœμΉ˜μ— 푸쉬해두고 과제 브랜치둜 λ°”κΏ”μ„œ 과제 μ½”λ“œ μž‘μ„±ν•˜μ‹œλ©΄ λ©λ‹ˆλ‹Ή~

@jsh6269
Copy link

jsh6269 commented Apr 13, 2024

LGTM μˆ˜κ³ ν–ˆμ–΄μš©

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants