Removed '_id' from being forced into each filter..#9
Open
deckchairhq wants to merge 1 commit intoSTRML:masterfrom
deckchairhq:patch-1
Open
Removed '_id' from being forced into each filter..#9deckchairhq wants to merge 1 commit intoSTRML:masterfrom deckchairhq:patch-1
deckchairhq wants to merge 1 commit intoSTRML:masterfrom
deckchairhq:patch-1
Conversation
Owner
|
The idea behind this was that users of the API would always need to access the internal id of an object so that we could reliably reference the object in further transactions, e.g. PUT requests and relations. I found it tedious to add '_id' to every single object, since it was guaranteed I would need it. There is probably a better way to expose this - perhaps there should be a default configuration, of fields that are automatically included in every filter, that is defaulted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is code specifically to let _id pass through the filter. What is the thinking behind this?
mongoose-filter-denormalize/lib/filter.js
Line 107 in f5cdb9a
If you wish to use slugs or other unique tags to reference your objects, internal id's are unnecessary to expose to the public.
In my case, I am exposing the id but wish to expose it as 'id' not '_id'. This is easily achieved on the schema with the following snippet (Mongoose automatically makes 'id' a virtual schema object, which is purely an ObjectId pre-casted to a hex string):