Skip to content

os/board/rtl8730e: Optimize the CFLAGS length #7035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EangJS wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

os/board/rtl8730e: Optimize the CFLAGS length #7035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions os/board/rtl8730e/src/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ else

endif

# Generate response file containing all CFLAGS
CFLAGS_FILE := $(TOPDIR)/cflags.rsp
Copy link
Collaborator

@r-prabu r-prabu Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CFLAGS response file approach is a valid solution for addressing command line length limitations. However, the implementation should be carefully integrated with the existing build system to ensure robustness and maintainability. The approach is particularly useful for complex builds with many include paths and definitions.

$(shell printf "%s" "$(CFLAGS)" > $(CFLAGS_FILE))
CFLAGS := @$(CFLAGS_FILE)

all: libboard$(LIBEXT)

$(AOBJS): %$(OBJEXT): %$(ASMEXT)
Expand Down