Skip to content

Conversation

@SchemingCate
Copy link
Owner

@SchemingCate SchemingCate commented Mar 12, 2023

  1. Task: https://github.com/DrDiman/CSS-Bayan-task

  2. Screenshot:
    Screenshot 2023-03-12 at 23 46 40

  3. Deploy: https://schemingcate.github.io/cssBayan/cssBayan

  4. Done 12.03.2023 / deadline 13.03.2023

  5. Score: 140 / 140

  • Everything is done from Repository requirements and how to submit task section (30/30)
  • The accordion component is centred on the screen, with equal indents on the left and right (10/10)
  • Icons, meme texts and meme images exist (5/5)
  • Placement of the meme, icons and meme text are the same as in provided example gif images (5/5)
  • Smooth change (transition) of the meme images and icons is done (20/20)
  • Responsive design with three breakpoints for mobile, tablet, and desktop exist. Accordion is displayed correctly at mobile 320x568, tablet 820x1180, desktop 1920×1080. (Note: breakpoints don't have to be 320x568, 820x1180, 1920x1080). (10/10)
    Note for reviewer: брейкпоинты реализованы на 425px, 820px и 1024px
  • All visual effects when the cursor is hovering over the memes, when the mouse is down on a meme, and when a meme is selected are implemented (10/10)
  • The entire row (text, icon, and meme image) clickable (5/5)
  • Cursor over the memes (hover) effect only exists for devices that can support hover. (10/10)
    Note for reviewer: в работе ховер привязан не к размеру девайса, а к типу. Для проверки пункта через ПК необходимо в devtools поменять тип (не расширение) девайса c Desktop на Mobile
  • The cursor when it is hovering over the rows of the accordion is changing (5/5)
  • Only flexible dimensions are used rem, em, %, vh, vw, fr and etc... The accordion is responsive (10/10)
  • All blocks/parts of the accordion are in base flow of the dom elements. All elements are not positioned with top, left, right, bottom. float is not used. The value of position is only static (5/5)
  • Pseudo-elements are not used (note 1: pseudo-classes are allowed; note 2: pseudo-elements only from FontAwesome are allowed) (5/5)
  • Initially, the first meme should be expanded (5/5)
  • Font size is changed at each device (mobile, tablet, desktop) (5/5)

Thank you for the review! Спасибо за проверку!

If you have any questions, feel free to contact me. My Discord: CatTheAlly#6904
Если возникнут какие-либо вопросы, можете написать мне. Мой Дискорд: CatTheAlly#6904

@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 13:39 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 14:04 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 16:16 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 16:25 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 18:57 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 18:58 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 19:17 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 19:58 — with GitHub Pages Inactive
@SchemingCate SchemingCate temporarily deployed to github-pages March 12, 2023 20:24 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants