Merged
Conversation
- Replace `@warn` with `Base.depwarn` in `read_cellml` so the deprecation is properly caught by `--depwarn=error` - Use `!==` instead of `!=` for `nothing` comparison in `update_list!` for type-stable comparison Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@warnwithBase.depwarninread_cellmlso the deprecation is properly caught by--depwarn=error. Previously, usingread_cellmlonly emitted a logging warning that was invisible to Julia's deprecation warning system.!==instead of!=fornothingcomparison inupdate_list!for type-stable comparison.Testing
All tests pass with
Pkg.test(; julia_args=["--depwarn=error"])(17/17 tests pass across QA, beeler, and noble_1962 test sets).Upstream dependency notes
No upstream deprecation issues found. The package already uses current ModelingToolkit v10 APIs:
System(notODESystem)mtkcompile(notstructural_simplify)unknowns(notstates)ModelingToolkit.defaults,ModelingToolkit.isparameter,@set!on system fields, and theODEProblemconstructor with combined pairs array all work without deprecation warnings on the current dependency versions.🤖 Generated with Claude Code