Skip to content

Fix downgrade tests#3047

Open
ParamThakkar123 wants to merge 81 commits intoSciML:masterfrom
ParamThakkar123:fix/downgrade_tests
Open

Fix downgrade tests#3047
ParamThakkar123 wants to merge 81 commits intoSciML:masterfrom
ParamThakkar123:fix/downgrade_tests

Conversation

@ParamThakkar123
Copy link
Copy Markdown
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ParamThakkar123
Copy link
Copy Markdown
Contributor Author

The downgrade tests got skipped :(

@ChrisRackauckas
Copy link
Copy Markdown
Member

You have to re-enable them

@ParamThakkar123
Copy link
Copy Markdown
Contributor Author

@ChrisRackauckas All downgrade tests seem to pass. I think the one that fails isn't able to find julia executable due to some reason. I will retrigger this before merging to ensure it passes

@ParamThakkar123
Copy link
Copy Markdown
Contributor Author

@ChrisRackauckas

Run julia-actions/setup-julia@v2
Error: Unable to locate executable file: julia. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

getting this from the CI

@ChrisRackauckas
Copy link
Copy Markdown
Member

That's because the machine ran out of memory. Just rerun 😅

@ParamThakkar123
Copy link
Copy Markdown
Contributor Author

@ChrisRackauckas There's an error in the CI which says:

ERROR: LoadError: could not find manifest entry for package with uuid bbf590c4-e513-4bbe-9b18-05decba2e5d8
Stacktrace:
  [1] pkgerror(msg::String)
    @ Pkg.Types ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/Types.jl:68
  [2] _get_deps!(collected_uuids::Set{Base.UUID}, env::Pkg.Types.EnvCache, new_uuids::Set{Base.UUID})
    @ Pkg.Operations ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1009
  [3] _get_deps!(collected_uuids::Set{Base.UUID}, env::Pkg.Types.EnvCache, new_uuids::Set{Base.UUID})
    @ Pkg.Operations ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1013
  [4] get_deps
    @ ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:998 [inlined]
  [5] build(ctx::Pkg.Types.Context, uuids::Set{Base.UUID}, verbose::Bool)
    @ Pkg.Operations ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1033
  [6] build(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; verbose::Bool, kwargs::@Kwargs{io::IOContext{IO}})
    @ Pkg.API ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:1110
  [7] build(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOContext{IO}, kwargs::@Kwargs{verbose::Bool})
    @ Pkg.API ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:159
  [8] build(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::@Kwargs{verbose::Bool})
    @ Pkg.API ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:174
  [9] build
    @ ~/github-runners/demeter4-17/_work/_tool/julia/1.11.9/x64/share/julia/stdlib/v1.11/Pkg/src/API.jl:165 [inlined]
 [10] (::Base.var"#106#108"{Base.var"#106#107#109"{ExponentialBackOff, Nothing, typeof(Pkg.API.build)}})(; kwargs::@Kwargs{verbose::Bool})
    @ Base ./error.jl:312
 [11] top-level scope
    @ ~/github-runners/demeter4-17/_work/_temp/1c93ef2d-2331-42cd-ae8a-95c0f3b77930:32
in expression starting at /home/chrisrackauckas/github-runners/demeter4-17/_work/_temp/1c93ef2d-2331-42cd-ae8a-95c0f3b77930:32

I tried the path approach where I added the paths of OrdinaryDiffEqCore to some libraries. Is there a better fix for this ?

@ChrisRackauckas
Copy link
Copy Markdown
Member

tests fail

@ParamThakkar123
Copy link
Copy Markdown
Contributor Author

@ChrisRackauckas I retriggered CI but the Downgrade tests seem to fail with the same manifest error ? Should I rerun it with v2.2.2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants