test(Rosenbrock): update resize_tests for new cache fields (k₁/k₂/k₃ → ks, f₁ → dense)#3313
Open
singhharsh1708 wants to merge 2 commits intoSciML:masterfrom
Open
test(Rosenbrock): update resize_tests for new cache fields (k₁/k₂/k₃ → ks, f₁ → dense)#3313singhharsh1708 wants to merge 2 commits intoSciML:masterfrom
singhharsh1708 wants to merge 2 commits intoSciML:masterfrom
Conversation
… → ks, f₁ → dense)
| @test length(i.cache.k₁) == 5 | ||
| @test length(i.cache.k₂) == 5 | ||
| @test length(i.cache.k₃) == 5 | ||
| @test all(length.(i.cache.ks) .== 5) |
Member
There was a problem hiding this comment.
also test that there is the right number of ks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
resize_tests.jlto reflect the newRosenbrockCachestructure introduced in the RodasTableau refactor.The previous tests accessed fields specific to
Rosenbrock23Cache/Rosenbrock32Cache:k₁,k₂,k₃f₁These have been replaced in the unified
RosenbrockCachewith:ks(vector of stage values)dense(interpolation coefficients)Changes
Replaced:
k₁,k₂,k₃→ksf₁→denseUpdated assertions to validate vectorized structure:
all(length.(cache.ks) .== N)all(length.(cache.dense) .== N)Rationale
The cache structure was unified as part of the RodasTableau migration, so tests need to align with the new representation.
No changes to solver behavior — this only updates tests to match the new internal structure.
Test for #3273
Checklist