Fix email rendering not throwing errors#80
Merged
Conversation
CarsonF
added a commit
to SeedCompany/cord-api-v3
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered a problem where our async templates were being sent without data.
I now believe there were errors encountered, but instead of those being thrown, they were swallowed.
SeedCompany/cord-api-v3#3585
I added tests to confirm async rendering works & throwing errors are actually thrown.
Unfortunately I had to inline the rendering library because it appears that its latest release doesn't correctly handle error throwing.