Open
Conversation
807fef5 to
5c9ccfd
Compare
Author
|
I might change this hardware configuration to |
12 tasks
Collaborator
|
ACK and tested in RaspiOS. Still need to test with seedsigner-os. I also don't have a ili9341 screen/board to test on. |
Author
|
Appreciate the review @newtonick ! |
Collaborator
|
Tested with SeedSignerOS |
Collaborator
|
The changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the change simply. Provide a reason for the change.
This PR adds some new structures to the
settings_definition.pywhich define what hardware/GPIOs are being used. Then it uses this structure for both the buttons and the 3 different LCD displays to configure GPIO.It also cleans up the
buttons.pycode a bit so that GPIO pin numbers aren't defined in the same file twice.Over time I have made various PRs for porting Seedsigner to the Luckfox Pico hardware, and the link below is the latest one. (Please look at the PR, commit by commit, if you are curious. I spent a lot of time making clean commit structure)
lightningspore#8
This PR is the first step in a series of PRs to enable that new hardware platform. But this PR has managed to limit the scope greatly, in order to provide some convenience without actually changing any underlying libraries.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This PR doesn't change any functionality, so no new screenshots.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRThe dev branch is currently failing some translation related tests, but it was like that before.
If you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
I tested it on a Raspberry Pi 3A+ running latest Bookworm 12, and commented out the camera imports. Also tested on a RPi 0.
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.