Skip to content

feat: add type hints for span partitioning functions in app_helper.py #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsantacruz merged 1 commit into from
Oct 19, 2025
Merged

feat: add type hints for span partitioning functions in app_helper.py #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/app_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from functools import reduce
from collections import defaultdict
from ne_span import NESpan


BATCH_SIZE = 150
Expand Down Expand Up @@ -35,7 +36,7 @@ def _get_linker_entities(text, ner_model, ref_part_model):
return cit_spans, ref_parts, other_spans


def _partition_spans(spans):
def _partition_spans(spans: list[NESpan]):
cit_spans, other_spans = [], []
for span in spans:
if LABEL2TYPE.get(span.label) == 'citation':
Expand All @@ -45,7 +46,7 @@ def _partition_spans(spans):
return cit_spans, other_spans


def _bulk_partition_spans(spans_list):
def _bulk_partition_spans(spans_list: list[list[NESpan]]):
cit_spans_list, other_spans_list = [], []
for spans in spans_list:
inner_cit_spans, inner_other_spans = _partition_spans(spans)
Expand Down