PlPython trampoline allows calls from plpython to multicorn FDW instance and vice versa.#250
Open
rbiro wants to merge 36 commits intoSegfault-Inc:masterfrom
Open
PlPython trampoline allows calls from plpython to multicorn FDW instance and vice versa.#250rbiro wants to merge 36 commits intoSegfault-Inc:masterfrom
rbiro wants to merge 36 commits intoSegfault-Inc:masterfrom
Conversation
when we have a transaction context and can let plpython do most of the work for us.
it actually expects.
utils.py and to make sure the oid is passed in the modstate. So far it only attempts to support insert. Once that is working, we can extend it to the others without much trouble.
…e from a foreign table oid. Use utils.getInstaceByOID to call functions that don't thake arguments.
…rampoline. Simplified trampoline and wrapped the rest of the functions.
…safe. Remebered to do an INCREF before returning a python object. Fixed the python 2.7 tests to include the context line in the ouput.
… get the transaction memory context as our base. Otherwise we might not get a valid context.
…e missing calls to iterate which could reasonable want to call back into plpy.
…ForeignPlan. Neither function appears to need to be wrapped.
… an inifinite loop.
rbiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps the insert calls and the commit calls in plpython so we can use plpy calls.
It passes minimal testing, so it's a good place to stop and ask for comments.