[javascript] Add headless flag to internal Chrome tests#17079
[javascript] Add headless flag to internal Chrome tests#17079ElliotNewtonMiller wants to merge 1 commit intoSeleniumHQ:trunkfrom
Conversation
PR TypeBug fix Description
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
Why is this needed? Isn't there already a |
🔗 Related Issues
💥 What does this PR do?
Make internal javascript testing on Chrome headless because Chromedriver will otherwise not connect with Chrome.
This change was implimented in the internal testing
Environmentobject.🔧 Implementation Notes
I used the Environment object in the "testing/index.js" file because it seemed to be solely used for internal testing (in Bazel), which is the only place this bug exists.
I considered trying to add environment flags via Bazel commands.
💡 Additional Considerations
The tests don't all pass. Hopefully fixing them can be my focus in future PRs.
🔄 Types of changes