Skip to content

[dotnet] Hide unnecessary chromium public fields #17113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvborisenko wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[dotnet] Hide unnecessary chromium public fields #17113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions dotnet/src/webdriver/Chromium/ChromiumDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,77 +32,77 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
/// <summary>
/// Accept untrusted SSL Certificates
/// </summary>
public static readonly bool AcceptUntrustedCertificates = true;
protected static readonly bool AcceptUntrustedCertificates = true;

/// <summary>
/// Command for executing a Chrome DevTools Protocol command in a driver for a Chromium-based browser.
/// </summary>
public static readonly string ExecuteCdp = "executeCdpCommand";
protected static readonly string ExecuteCdp = "executeCdpCommand";
Comment on lines +35 to +40
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing these members from public to protected is a breaking source and binary API change (existing compiled consumers can start throwing MissingFieldException). Repo guidance calls out maintaining API/ABI compatibility and using a deprecation cycle before removing public functionality (see AGENTS.md:12 and AGENTS.md:65-67; dotnet/AGENTS.md:26-30). Consider keeping the public fields for now but marking them [Obsolete] (and optionally [EditorBrowsable(EditorBrowsableState.Never)]) so they’re hidden from IntelliSense, then remove in a later release.

Copilot uses AI. Check for mistakes.

/// <summary>
/// Command for getting cast sinks in a driver for a Chromium-based browser.
/// </summary>
public static readonly string GetCastSinksCommand = "getCastSinks";
protected static readonly string GetCastSinksCommand = "getCastSinks";

/// <summary>
/// Command for selecting a cast sink in a driver for a Chromium-based browser.
/// </summary>
public static readonly string SelectCastSinkCommand = "selectCastSink";
protected static readonly string SelectCastSinkCommand = "selectCastSink";

/// <summary>
/// Command for starting cast tab mirroring in a driver for a Chromium-based browser.
/// </summary>
public static readonly string StartCastTabMirroringCommand = "startCastTabMirroring";
protected static readonly string StartCastTabMirroringCommand = "startCastTabMirroring";

/// <summary>
/// Command for starting cast desktop mirroring in a driver for a Chromium-based browser.
/// </summary>
public static readonly string StartCastDesktopMirroringCommand = "startCastDesktopMirroring";
protected static readonly string StartCastDesktopMirroringCommand = "startCastDesktopMirroring";

/// <summary>
/// Command for getting a cast issued message in a driver for a Chromium-based browser.
/// </summary>
public static readonly string GetCastIssueMessageCommand = "getCastIssueMessage";
protected static readonly string GetCastIssueMessageCommand = "getCastIssueMessage";

/// <summary>
/// Command for stopping casting in a driver for a Chromium-based browser.
/// </summary>
public static readonly string StopCastingCommand = "stopCasting";
protected static readonly string StopCastingCommand = "stopCasting";

/// <summary>
/// Command for getting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
public static readonly string GetNetworkConditionsCommand = "getNetworkConditions";
protected static readonly string GetNetworkConditionsCommand = "getNetworkConditions";

/// <summary>
/// Command for setting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
public static readonly string SetNetworkConditionsCommand = "setNetworkConditions";
protected static readonly string SetNetworkConditionsCommand = "setNetworkConditions";

/// <summary>
/// Command for deleting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
public static readonly string DeleteNetworkConditionsCommand = "deleteNetworkConditions";
protected static readonly string DeleteNetworkConditionsCommand = "deleteNetworkConditions";

/// <summary>
/// Command for executing a Chrome DevTools Protocol command in a driver for a Chromium-based browser.
/// </summary>
public static readonly string SendChromeCommand = "sendChromeCommand";
protected static readonly string SendChromeCommand = "sendChromeCommand";

/// <summary>
/// Command for executing a Chrome DevTools Protocol command that returns a result in a driver for a Chromium-based browser.
/// </summary>
public static readonly string SendChromeCommandWithResult = "sendChromeCommandWithResult";
protected static readonly string SendChromeCommandWithResult = "sendChromeCommandWithResult";

/// <summary>
/// Command for launching an app in a driver for a Chromium-based browser.
/// </summary>
public static readonly string LaunchAppCommand = "launchAppCommand";
protected static readonly string LaunchAppCommand = "launchAppCommand";

/// <summary>
/// Command for setting permissions in a driver for a Chromium-based browser.
/// </summary>
public static readonly string SetPermissionCommand = "setPermission";
protected static readonly string SetPermissionCommand = "setPermission";

private readonly string optionsCapabilityName;
private DevToolsSession? devToolsSession;
Expand Down