-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[java] Enhance ScriptKey.toString() and mask script content in UnpinnedScriptKey #17159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asolntsev
merged 5 commits into
SeleniumHQ:trunk
from
seethinajayadileep:enhancement/scriptkey-add-tostring-clean
Mar 2, 2026
+96
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a7d1dff
Add toString() to ScriptKey for improved debugging readability
seethinajayadileep f4a0071
Avoid logging raw script content in UnpinnedScriptKey.toString()
seethinajayadileep dca4a93
Merge branch 'trunk' into enhancement/scriptkey-add-tostring-clean
cgoldberg 2a9b9c2
[java] Add unit tests for ScriptKey and UnpinnedScriptKey toString() …
seethinajayadileep cb1caa1
[java] Refine UnpinnedScriptKey.toString() and update corresponding t…
seethinajayadileep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| package org.openqa.selenium; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ScriptKeyTest { | ||
| @Test | ||
| void hasToStringEqualToIdentifier() { | ||
| assertThat(new ScriptKey("xxx")).hasToString("xxx"); | ||
| } | ||
|
|
||
| @Test | ||
| void hasToStringWorksForEmptyIdentifier() { | ||
| assertThat(new ScriptKey("")).hasToString(""); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.openqa.selenium; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class UnpinnedScriptKeyTest { | ||
|
|
||
| @Test | ||
| void toStringDoesNotExposeRawScript() { | ||
| String script = "return 'SECRET_TOKEN';"; | ||
| UnpinnedScriptKey key = new UnpinnedScriptKey(script); | ||
|
|
||
| assertThat(key.toString()).doesNotContain(script); | ||
| } | ||
|
|
||
| @Test | ||
| void toStringContainsScriptIdWhenPresent() { | ||
| UnpinnedScriptKey key = new UnpinnedScriptKey("return 1;"); | ||
| key.setScriptId("script-99"); | ||
|
|
||
| String value = key.toString(); | ||
|
|
||
| assertThat(value).contains("UnpinnedScriptKey{"); | ||
| assertThat(value).contains("scriptId=script-99"); | ||
| assertThat(value).contains("length="); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.