Added support for Elvaco CMa10 send text feature #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ref to new send custom text func
You need to set the secondary address inside the .py for this test
Finally working, I guess I should have better git management
add send_custom_text, probably not important but I will use it a lot so I want it there with the rest of them
Byte conversion added, now you can input normal string to send_custom_text
…text.py Test for new send custom text function
Remove the parse xml stuff because it doesn't work on an E5 reply
Found a way to except a wrong address / device offline
One more fix to the reply
Info about send_custom_text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I used your fork back in the day because it apparently had fixed some issues on the seemingly abandoned original. I just created a pull request for the C library to the master and I figured I should create a pull request here too so it may end up upstream
The functionalities I added are working correctly, stable and in use, although documentation and fool proof may not be adequate enough