-
Notifications
You must be signed in to change notification settings - Fork 0
Stage-2 data class #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ievetrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хорошо, едем дальше. Но ветки скорее всего надо в порядок привести
|
@ievetrov будет сделано) |
ievetrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Оставил несколько комментариев. Пока из основного, это что нужно упорядочить код
| val word = Word(original = line[0], translate = line[1]) | ||
| dictionary.add(word) | ||
| } | ||
| var correctAnswersCount = 0 //Счётчик для выученных слов |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это не просто переменная, а поле класса Word. такая же часть сущности, как и оригинал и перевод
| } | ||
| var correctAnswersCount = 0 //Счётчик для выученных слов | ||
|
|
||
| /* val dictionary2 = dictionary.filter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
какая функция этого комментария?
| }*/ | ||
| val dictionary2 = dictionary | ||
| for (i in dictionary2){ | ||
| println("Как переводится слово: ${i.original}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
этого задания нет в описании этапа
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и мы используем только 1 словарь. это то, что получено из файла
|
|
||
|
|
||
|
|
||
| do{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут достаточно классического цикла while true
|
|
||
|
|
||
| val quantityWords = dictionary.size //Количество слов в словаре | ||
| val percentageRatio = (correctAnswersCount.toFloat() / quantityWords.toFloat()) * 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
33 и 34 лучше перенести туда , где они используются. там же добывать правильные слова. нужен порядок в коде. чтобы ничего лишнего не было за пределами when/цикла, если это не переиспользуется еще где-то
No description provided.