feat(player): show video stats icon in theatre mode#1211
Open
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Open
feat(player): show video stats icon in theatre mode#1211dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Conversation
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #1162
Video stats icon was only rendered in the stream info bar below the video, which is hidden in theatre mode. This made the stats inaccessible for users who exclusively use theatre mode.
Fix adds theatre mode detection in
PlayerStreamInfo.vueusing aMutationObserverthat watches for thepersistent-player--theatreclass being added or removed. When theatre mode is active, stats icon mounted into.player-controls__right-control-groupinstead, appearing on hover alongside other player controls. When exiting theatre mode it returns to its normal position.Tested: stats icon appears correctly in theatre mode on hover, and returns to its normal position when exiting theatre mode.
Note: Pre-existing issue exists where stats icon doesn't appear on fresh page load until the setting is toggled off/on. This predates this fix.
Types of changes
Checklist
Images
In Theatre Mode (visible on hover like the rest of the normal buttons)