-
Notifications
You must be signed in to change notification settings - Fork 1k
SharePointEmbeddedContainerTypeManagementUsingGraph #10569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SharePointEmbeddedContainerTypeManagementUsingGraph #10569
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 8c08a98:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/getting-started/containertypes-graph.md | View | Details | |
| docs/embedded/getting-started/containertypes.md | View | Details | |
| docs/embedded/images/CTCreationAppRegistration.png | View | Details | |
| docs/embedded/images/CTCreationGraphPerms.png | View | Details | |
| docs/embedded/images/CTCreationOverview.png | View | Details |
docs/embedded/getting-started/containertypes-graph.md
- Line 2, Column 8: [Warning: duplicate-titles - See documentation]
Title 'Create New SharePoint Embedded Container Types' is duplicated in: 'embedded/getting-started/containertypes-graph.md(2,8), embedded/getting-started/containertypes.md(2,8)'. Titles must be unique within a docset. - Line 8, Column 1: [Warning: duplicate-h1s - See documentation]
H1 'SharePoint Embedded Container Types' is duplicated with other articles: 'embedded/getting-started/containertypes-graph.md(8,1), embedded/getting-started/containertypes.md(8,1)'. First level headings must be unique within a docset. - Line 72, Column 1: [Warning: duplicate-h2s - See documentation]
Duplicate heading: 'H2 'Creating Container Types''. Each second level heading (H2) in an article must be unique. - Line 119, Column 1: [Warning: duplicate-h2s - See documentation]
Duplicate heading: 'H2 'Creating Container Types''. Each second level heading (H2) in an article must be unique. - Line 128, Column 71: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/graph/graph-explorer/graph-explorer-overview?view=graph-rest-1.0%2F%3FWT.mc_id%3Dmsgraph_inproduct_graphexhelp' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed. - Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'This article explains how Container Types work and the steps to create new Container Types.' is duplicated in 'embedded/getting-started/containertypes-graph.md(3,14)', 'embedded/getting-started/containertypes.md(3,14)'. - Line 60, Column 73: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'alt text' is duplicated. Within an article, alt text must be unique. - Line 69, Column 5: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'alt text' is duplicated. Within an article, alt text must be unique. - Line 128, Column 71: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/graph/graph-explorer/graph-explorer-overview?view=graph-rest-1.0%2F%3FWT.mc_id%3Dmsgraph_inproduct_graphexhelp' will be broken in isolated environments. Replace with a relative link. - Line 128, Column 71: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/graph/graph-explorer/graph-explorer-overview?view=graph-rest-1.0%2F%3FWT.mc_id%3Dmsgraph_inproduct_graphexhelp
docs/embedded/getting-started/containertypes.md
- Line 2, Column 8: [Warning: duplicate-titles - See documentation]
Title 'Create New SharePoint Embedded Container Types' is duplicated in: 'embedded/getting-started/containertypes-graph.md(2,8), embedded/getting-started/containertypes.md(2,8)'. Titles must be unique within a docset. - Line 8, Column 1: [Warning: duplicate-h1s - See documentation]
H1 'SharePoint Embedded Container Types' is duplicated with other articles: 'embedded/getting-started/containertypes-graph.md(8,1), embedded/getting-started/containertypes.md(8,1)'. First level headings must be unique within a docset. - Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'This article explains how Container Types work and the steps to create new Container Types.' is duplicated in 'embedded/getting-started/containertypes-graph.md(3,14)', 'embedded/getting-started/containertypes.md(3,14)'.
docs/embedded/images/CTCreationAppRegistration.png
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names. - Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/embedded/images/CTCreationGraphPerms.png
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names. - Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/embedded/images/CTCreationOverview.png
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names. - Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
andrewconnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission @Spucelik... I added some single comments in the new doc, but overall, the following things should be addressed:
- remove unnecessary extra line breaks
- images need descriptive titles/alt text for screen readers and accessibility (msdocs requirement)
- all automated build issues (see this comment from the build check report) need to be resolved (including warnings) before we can merge this content in
- if you have issues resolving some of them, just leave a comment on your next update and I can fix one to show you what it's complaining about
- Some of these are found by running the doc thru Acrolix, a contnet checking tool MSDOCS makes available... there's an internal doc in the MSLearn/MSDocs documentation site... I don't have access to the site ATM as my V- hasn't been reactivated for this FY quarter yet, but you should be able to find it internally... it's a VSCode extension that will find, and fix, a lot of these issues as it uses the same rules the automated checker finds.
Note that I called out some of the issues in single comments, but some are found in numerous places throughout the doc (like extra line breaks).
|
|
||
| ### Create an Azure App Registration | ||
|
|
||
| 1. Login to portal.azure.com -> Microsoft Entra ID -> App Registrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numbered bullets should always start with 1. ... let the markdown rendering engine number them
| 1. Login to portal.azure.com -> Microsoft Entra ID -> App Registrations | ||
| 2. Create a New Registration | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use spaces, not html spaces for indentations. If you're trying to indent this image within the bullet list, it should have 4 spaces
| - An Azure subscription in the tenancy | ||
| - A resource group attached to the Azure subscription | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra line breaks
|
|
||
| SharePoint Embedded has 2 different Container Types you can create. | ||
|
|
||
| 1. Trial Container Type - provides a temporary, limited‑usage environment that lets developers explore and test the platform’s storage, permissions, and API capabilities before moving to production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only use 1 space between bullet points and the text
|
|
||
|
|
||
| ## Creating Container Types | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra line breaks
|
|
||
|
|
||
| ```http | ||
| PUT IN RESPONSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this? seems like it's incomplete
|
|
||
| With the standard billing profile, all consumption-based charges are directly billed to the tenant who owns or develops the application. The admin in the developer tenant must establish a valid billing profile when creating a standard container type. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use more descriptive titles for images for accessibility (screen readers)... this is an MSDOCS req
| ResourceGroup : prod-resources | ||
| Region : EastUS | ||
| ``` | ||
| ## Updating Container Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have an empty line between code block & heading
Category
Related issues
What's in this Pull Request?