Improve isValidMatch logic by adding firstReleasedYear parameter and update related tests

[Ziedelth]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Ziedelth, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the media matching logic within the AniListCachedWrapper by introducing a firstReleasedYear parameter to the isValidMatch function. This enhancement allows for more accurate identification of media by considering its release year, particularly for entries without direct parent relations. Additionally, the definition of character-based spinoffs has been made more robust by excluding 'TV_SHORT' formats. These changes are supported by a new dedicated test case to ensure their correctness and prevent regressions.

Highlights

• Improved Matching Logic: The isValidMatch function now accepts an optional firstReleasedYear parameter, allowing for more precise matching by incorporating the release year into the criteria for media without parent relations and within a specific release year range.
• Updated hasUniqueValidMatch Calculation: The calculation for hasUniqueValidMatch has been updated to correctly pass the new firstReleasedYear argument to the modified isValidMatch function.
• Refined Spinoff Detection: The logic for identifying character-based spinoffs (isCharacterSideStory) has been expanded to exclude 'TV_SHORT' format media, alongside 'TV' and 'MOVIE', from being considered as character spinoffs.
• New Test Case: A new MediaTestCase for 'ISEKAI QUARTET' has been added to AniListCachedWrapper.kt to validate the updated matching logic, specifically testing the firstReleasedYear parameter.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the matching logic in AniListCachedWrapper by incorporating firstReleasedYear into the isValidMatch function for a more precise match. The related tests are updated accordingly, and a small fix is included for character side story relation logic. My review includes a suggestion to simplify the new logic in isValidMatch for better readability.

[gemini-code-assist]

The logic in this function can be simplified for better readability. The expression media.isFirstReleasedYearRange && (firstReleasedYear == null || media.startDate.year == firstReleasedYear) is functionally correct but contains redundant checks.

The media.isFirstReleasedYearRange check is redundant because media.startDate.year == firstReleasedYear already implies that the year is within the range defined in isFirstReleasedYearRange. The entire condition effectively simplifies to checking for an exact year match when firstReleasedYear is not null.

Here's a simplified version that is easier to understand:

Suggested change

	private fun isValidMatch(media: Media, firstReleasedYear: Int?): Boolean =
	hasHighSimilarity(media) || (!media.hasParentRelation && media.isFirstReleasedYearRange && (firstReleasedYear == null || media.startDate.year == firstReleasedYear))
	private fun isValidMatch(media: Media, firstReleasedYear: Int?): Boolean =
	hasHighSimilarity(media) || (!media.hasParentRelation && firstReleasedYear != null && media.startDate.year == firstReleasedYear)