Update modal close button accessibility label #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

spencercanner wants to merge 1 commit into main from modal-close-label

spencercanner commented Nov 9, 2020 •

edited

Loading

Change aria-role="hidden" to aria-hidden="true" to ensure the X is not announced by the screen reader
Add text object to default modal config that contains the closeAccessibilityLabel

To 🎩 :

Create a buy button where the button destination is modal
Navigate a virtual cursor to the product button, and click it to open the modal
Verify that the modal close button does not announce the X
Verify that the modal close button announces accessibility label Close

Chrome (Sanity check)
Safari/Mac VoiceOver
Firefox/Windows NVDA


          update modal close button accessibility label

f28a35b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet