Skip to content

Conversation

@spencercanner
Copy link

@spencercanner spencercanner commented Nov 12, 2020

  • Rearrange the line item elements so the quantity comes before price in the dom
  • This allows merchants using a screen reader to access the total line item price after making updates to the quantity

To 🎩 :

  • Verify that the line item styling/layout is not affected by these changes
    • Line item without discounts

  • Line item with discounts

  • Sanity check other line item configs work as expected:
    • contents > priceWithDiscounts: false, price: true
    • contents > quantity: false, priceWithDiscounts: true
    • contents > quantity: false, price: true
    • order >price, priceWithDiscounts, quantity

Windows:

  • Legacy Edge 18
  • Legacy Edge 17
  • Chromium Edge 86
  • Chromium Edge 85
  • Firefox 82
  • Firefox 81
  • Chrome 86
  • Chrome 85
  • Opera 72
  • Opera 71
  • IE11

Mac:

  • Safari 13
  • Safari 12
  • Safari 8
  • Firefox 82
  • Firefox 81
  • Chrome 86
  • Chrome 85
  • Chromium Edge 86
  • Chromium Edge 85
  • Opera 72
  • Opera 71

iOS (SE):

  • Safari
  • Chrome

iOS (11):

  • Safari
  • Chrome

Android (Samsung S10):

  • Chrome
  • Firefox
  • Samsung Internet

Android (Moto G):

  • Chrome
  • Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant