Skip to content

Don't reserve nil when there are no tests left #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidstosik merged 1 commit into from
Aug 26, 2025
Merged

Don't reserve nil when there are no tests left #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ruby/lib/ci/queue/redis/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ def raise_on_mismatching_test(test)
end

def reserve
test = (try_to_reserve_lost_test || try_to_reserve_test)
reserved_tests << test
test
(try_to_reserve_lost_test || try_to_reserve_test).tap do |test|
reserved_tests << test if test
end
end

def try_to_reserve_test
Expand Down
Loading