Merged
Conversation
Edouard-chin
force-pushed
the
ec-date-fix
branch
4 times, most recently
from
476f8b2 to
965222a
Compare
- The previous code would not work when a gem Rakefile includes
a compiler task that has a dynamic `lib_dir`.
For instance:
```ruby
Rake::ExtensionTask.new("date") do |ext|
ext.lib_dir = "lib/#{RUBY_VERSION}"
end
```
In this case, when the compilation starts, the runtime ruby would
be on Ruby 3.1.7, so the binaries would be located in
`tmp/stage/lib/3.1.7/3.4/date.so`.
Then once we want to try running the test suite for Ruby 3.4,
we'd evaluate the ExtensionTask again and we'd try to copy
`tmp/stage/lib/3.4.7/3.4/date.so` which doesn't exist.
The fix in this patch is to copy everything in the `tmp/stage/*`
folder at the root of the repo.
Edouard-chin
force-pushed
the
ec-date-fix
branch
from
60a287d to
406e388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy stating files to the root of the project:
The previous code would not work when a gem Rakefile includes a compiler task that has a dynamic
lib_dir.For instance:
In this case, when the compilation starts, the runtime ruby would be on Ruby 3.1.7, so the binaries would be located in
tmp/stage/lib/3.1.7/3.4/date.so.Then once we want to try running the test suite for Ruby 3.4, we'd evaluate the ExtensionTask again and we'd try to copy
tmp/stage/lib/3.4.7/3.4/date.sowhich doesn't exist.The fix in this patch is to copy everything in the
tmp/stage/*folder at the root of the repo.