Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Oct 10, 2025

Related to https://github.com/shop/issues-develop/issues/21256

WHY are these changes introduced?

We are using Destinations API to fetch organization details, but that's not the right API to use for that (Documentation).

WHAT is this pull request doing?

Switch to Organizations API.

How to test your changes?

p shopify app deploy

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.03% (-0.2% 🔻)
13359/16904
🟡 Branches
72.72% (-0.39% 🔻)
6524/8972
🟡 Functions
79.22% (-0.15% 🔻)
3450/4355
🟡 Lines
79.39% (-0.19% 🔻)
12620/15896
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / find_organization.ts
100% 100% 100% 100%
🔴
... / deprecation-warnings.ts
0% 100% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / build.ts
0%
0% (-100% 🔻)
0% 0%
🔴
... / dev.ts
0%
0% (-100% 🔻)
0% 0%
🔴
... / replay.ts
0%
0% (-100% 🔻)
0% 0%
🔴
... / schema.ts
0%
0% (-100% 🔻)
0% 0%
🔴
... / list.ts
0%
0% (-100% 🔻)
0% 0%
🟢
... / app.ts
86.56% (-0.07% 🔻)
68.57%
93.55% (-0.1% 🔻)
88.27% (-0.07% 🔻)
🟢
... / loader.ts
93.32% (-0.54% 🔻)
85.92% (-0.91% 🔻)
97.22% (+0.16% 🔼)
94.3% (-0.37% 🔻)
🟢
... / extension-instance.ts
83.15% (-1.42% 🔻)
78.74% (+0.23% 🔼)
92.73% (+0.79% 🔼)
82.94% (-1.92% 🔻)
🟢
... / app_config_branding.ts
80% (-20% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
80% (-20% 🔻)
🟢
... / ui_extension.ts
94.78% (-0.04% 🔻)
82.89% (+1.64% 🔼)
100%
96.43% (-0.03% 🔻)
🟢
... / app-event-watcher.ts
97.73% (-0.47% 🔻)
91.43% (+2.54% 🔼)
95.45% (-1.21% 🔻)
100%
🟢
... / DevSessionUI.tsx
86.27% (+0.82% 🔼)
84.21% (+0.6% 🔼)
85% (-0.71% 🔻)
89.13% (+1.13% 🔼)
🟡
... / analytics.ts
83.33% (-1.28% 🔻)
47.62% 100%
78.95% (-1.05% 🔻)
🟢
... / api.ts
85.58% (-1.92% 🔻)
73.85% (-2.97% 🔻)
100%
85% (-1.92% 🔻)
🟢
... / device-authorization.ts
85.71% (-3.35% 🔻)
70.83% (-8.58% 🔻)
100%
85.71% (-3.35% 🔻)
🟢
... / archiver.ts
89.47% (+2.38% 🔼)
66.67%
75% (-1.47% 🔻)
92.31% (+1.08% 🔼)
🟢
... / base-command.ts
89.58% (-1.33% 🔻)
88.57% (-0.32% 🔻)
87.5% (-2.5% 🔻)
90.36% (-1.04% 🔻)
🔴
... / custom-oclif-loader.ts
28.13% (-4.23% 🔻)
11.9% (-3.31% 🔻)
33.33%
28.13% (-4.23% 🔻)
🟢
... / fs.ts
87.83% (-0.6% 🔻)
92.31% (+3.02% 🔼)
85.42% (-0.58% 🔻)
88.29% (-0.6% 🔻)
🟢
... / git.ts
91.92% (-1.24% 🔻)
88% (+0.07% 🔼)
90.48% (-0.43% 🔻)
92.71% (-1.63% 🔻)
🔴
... / deprecations.ts
0% (-8.33% 🔻)
0% 0%
0% (-8.33% 🔻)
🔴
... / postrun.ts
0% (-16.67% 🔻)
0%
0% (-25% 🔻)
0% (-18.75% 🔻)
🟢
... / output.ts
88.89%
64.29% (-7.14% 🔻)
88.89% 88.89%
🔴
... / theme-ui.ts
59.09% (-27.27% 🔻)
38.89% (-24.27% 🔻)
60% (-20% 🔻)
59.09% (-27.27% 🔻)
🟢
... / evaluator.ts
97.26% (-2.74% 🔻)
93.02% (-4.54% 🔻)
100%
97.14% (-2.86% 🔻)
🟢
... / html.ts
96.72% (-0.05% 🔻)
90.32% 88.89%
96.61% (-0.06% 🔻)
🟢
... / proxy.ts
91.54%
79.22% (-1.3% 🔻)
90% 91.15%

Test suite run success

3256 tests passing in 1342 suites.

Report generated by 🧪jest coverage report action from ab500ad

@github-actions
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@github-actions github-actions bot closed this Nov 18, 2025
@gonzaloriestra gonzaloriestra added stale-exempt If added, the PR/issue won't be closed by stale-bot and removed no-pr-activity labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale-exempt If added, the PR/issue won't be closed by stale-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant