Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Oct 30, 2025

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/21321

Alternative to #6554

30-50-gvxvz-gxqdi

WHAT is this pull request doing?

Detect when there are unsupported plugins and raise a handled (expected) error with instructions about how to remove them:

image

How to test your changes?

  • p shopify plugins add @shopify/app
  • p shopify app dev

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.21% (-0.01% 🔻)
13500/17044
🟡 Branches
73.06% (-0.01% 🔻)
6588/9017
🟡 Functions
79.22% (-0.03% 🔻)
3469/4379
🟡 Lines
79.58% (-0.01% 🔻)
12759/16033
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)
🟢
... / base-command.ts
86.67% (-2.92% 🔻)
87.5% (-1.07% 🔻)
82.14% (-5.36% 🔻)
87.91% (-2.45% 🔻)

Test suite run success

3319 tests passing in 1359 suites.

Report generated by 🧪jest coverage report action from 779ea91

@gonzaloriestra gonzaloriestra marked this pull request as ready for review October 30, 2025 11:38
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner October 30, 2025 11:38
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@gonzaloriestra gonzaloriestra force-pushed the improve-multiple-tunnel-plugins-error branch from 5573987 to 779ea91 Compare October 30, 2025 12:43
@gonzaloriestra gonzaloriestra changed the title Improve message for multiple tunnel plugins error Raise an error when there are unsupported plugins Oct 30, 2025
@gonzaloriestra
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -1,4 +1,4 @@
-import { Command } from '@oclif/core';
+import { Command, Config } from '@oclif/core';
 import { OutputFlags, Input, ParserOutput, FlagInput, OutputArgs } from '@oclif/core/parser';
 export type ArgOutput = OutputArgs<any>;
 export type FlagOutput = OutputFlags<any>;
@@ -45,4 +45,5 @@ export declare function addFromParsedFlags(flags: {
  * the user actually passed on the command line.
  */
 export declare function noDefaultsOptions<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options: Input<TFlags, TGlobalFlags, TArgs> | undefined): Input<TFlags, TGlobalFlags, TArgs> | undefined;
+export declare function warnOnUnsupportedPlugins(config: Config): Promise<void>;
 export default BaseCommand;
\ No newline at end of file

@github-actions
Copy link
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251030124433

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra
Copy link
Contributor Author

Closing in favor of #6554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant