-
Notifications
You must be signed in to change notification settings - Fork 218
Raise an error when there are unsupported plugins #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Coverage report
Show files with reduced coverage 🔻
Test suite run success3319 tests passing in 1359 suites. Report generated by 🧪jest coverage report action from 779ea91 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
5573987 to
779ea91
Compare
|
/snapit |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -1,4 +1,4 @@
-import { Command } from '@oclif/core';
+import { Command, Config } from '@oclif/core';
import { OutputFlags, Input, ParserOutput, FlagInput, OutputArgs } from '@oclif/core/parser';
export type ArgOutput = OutputArgs<any>;
export type FlagOutput = OutputFlags<any>;
@@ -45,4 +45,5 @@ export declare function addFromParsedFlags(flags: {
* the user actually passed on the command line.
*/
export declare function noDefaultsOptions<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options: Input<TFlags, TGlobalFlags, TArgs> | undefined): Input<TFlags, TGlobalFlags, TArgs> | undefined;
+export declare function warnOnUnsupportedPlugins(config: Config): Promise<void>;
export default BaseCommand;
\ No newline at end of file
|
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251030124433Caution After installing, validate the version by running just |
|
Closing in favor of #6554 |
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/21321
Alternative to #6554
WHAT is this pull request doing?
Detect when there are unsupported plugins and raise a handled (expected) error with instructions about how to remove them:
How to test your changes?
p shopify plugins add @shopify/appp shopify app devMeasuring impact
How do we know this change was effective? Please choose one:
Checklist