-
Notifications
You must be signed in to change notification settings - Fork 218
Refactoring function info command logic into service #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to service and adding unit tests
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3334 tests passing in 1369 suites. Report generated by 🧪jest coverage report action from 0afb7e0 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
gonzaloriestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactor! Tested that it works and left some minor comments
|
/snapit |
|
🫰✨ Thanks @saga-dasgupta! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251031143515Caution After installing, validate the version by running just |
Continuation of #6541
Fixes https://github.com/shop/issues-shopifyvm/issues/697
WHY are these changes introduced?
In my previous PR I had all the changes for function info command included in the command file which goes against the pattern of including most of the logic in the service file corresponding to the command so this PR fixes that and adds unit tests for the service file.
WHAT is this pull request doing?
Breaks the logic into the command file which is mostly orchestration:
And service file which is transformation/formatting:
How to test your changes?
npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251031143515shopify app function info --path <path to your function>shopify app function info --path <path to your function> --jsonPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist