-
Notifications
You must be signed in to change notification settings - Fork 16
Include localization support for POS UI extension templates #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Include localization support for POS UI extension templates #338
Conversation
aaronschubert0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're shipping this in 2026-01 that doesn't support React, can we just leave those templates as is and solely focus on the Preact / JS variants instead?
| type = "ui_extension" | ||
| name = "{{ name }}" | ||
| # Change the merchant-facing name of the extension in locales/en.default.json | ||
| name = "t:name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vctrchu just doubling checking does the CLI support non-english values here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to believe so based on the assumption that other extensions such as admin-block, etc follow this pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like its also publicly documented https://shopify.dev/docs/apps/build/app-extensions/configure-app-extensions#common-properties
|
@aaronschubert0 That works for me. I made this change before the fact I realized that the |
d3e8c1e to
0bec842
Compare

Resolves https://github.com/shop/issues-retail/issues/20278
DO NOT MERGE UNTIL 1/19/2026 / POS 10.19
Problem
POS extension templates (pos-action, pos-block, pos-smart-grid) did not include locale files or demonstrate i18n usage, making it unclear to developers how to internationalize their POS extensions. This was inconsistent with admin extension templates which fully demonstrate localization.
Solution
en.default.json.liquidandfr.json.liquidto all three POS templatesshopify.extension.toml.liquidto usename = "t:name"for locale-based extension namingshopify.i18n.translate()i18nfromuseApi()api.i18n.translate()Testing
dev cd clipnpm shopify app generate extension --clone-urlhttps://github.com/Shopify/extensions-templates#11-06-include_localization_support_for_pos_ui_extension_templates--path ./your-app-root