Skip to content

Conversation

@achitojha
Copy link
Contributor

@achitojha achitojha commented Dec 7, 2025

Background

This PR enhances the test configuration for all function templates to improve the developer experience when running tests.

Issue : https://github.com/shop/issues-shopifyvm/issues/755

Solution

Updated all vitest.config.js files to include forceRerunTriggers configuration, which ensures tests automatically rerun when changes are made to either test fixtures or source code. This improves the development workflow by providing immediate feedback when making changes to either test data or implementation code.

The configuration now watches for changes in:

  • **/tests/fixtures/** - Test data and fixtures
  • **/src/** - Source code files

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@achitojha achitojha marked this pull request as ready for review December 8, 2025 07:20
@achitojha achitojha requested a review from lopert December 8, 2025 07:20
Copy link
Contributor

@lopert lopert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 'd with cart validation, worked! re-ran when I changed the fixture or the source.

I'm adding a similar config to the rust functions in #348, ill port this over for the rust functions in that PR.

Copy link

@saga-dasgupta saga-dasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, file paths are correct and thats all the JS extensions. Would've asked what we're doing for rust functions but I see Alex would be taking care of that. 👍🏻

Copy link
Contributor Author

achitojha commented Dec 8, 2025

Merge activity

  • Dec 8, 7:15 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 8, 7:15 PM UTC: @achitojha merged this pull request with Graphite.

@achitojha achitojha merged commit f830860 into main Dec 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants