Add known failures support for expected test failures #107
+195
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetrick
approved these changes
Jan 8, 2026
|
|
||
| suite_specs.each do |spec| | ||
| complexity = spec.complexity || 1000 | ||
| is_known = known_failures.known_failure?(spec.name) |
There was a problem hiding this comment.
I'd slightly adjust the naming for clarity here to is_known_failure.
Allow marking specific tests as known failures that won't affect exit code: - --known-failures=FILE: load spec names from file (one per line, # comments) - config.known_failures = [...]: configure in adapter Known failures that now pass cause exit(1) with warning to update the list.
Maaarcocr
force-pushed
the
known-failures-support
branch
from
b1094ef to
a30d556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow marking specific tests as known failures that won't affect exit code:
Known failures that now pass cause exit(1) with warning to update the list.