Correct fully qualified global variable names#486
Merged
Conversation
Morriar
approved these changes
Jan 19, 2026
0d03bc5 to
1821c5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #128
I added a test to verify that all fully qualified names we generate are what we expect. All of them were already correct, with two exceptions:
Object. I believe this is fine for now, but we may want to revisit later. Global variables are accessible everywhere, so maybe for completion/go to definition algorithms, it will make more sense to place it inBasicObject? Or perhaps we need the magic<main>? I'll leave that to a dedicated PR