Skip to content

Correct fully qualified global variable names#486

Merged
vinistock merged 1 commit intomainfrom
01-19-correct_fully_qualified_global_variable_names
Jan 19, 2026
Merged

Correct fully qualified global variable names#486
vinistock merged 1 commit intomainfrom
01-19-correct_fully_qualified_global_variable_names

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Jan 19, 2026

Closes #128

I added a test to verify that all fully qualified names we generate are what we expect. All of them were already correct, with two exceptions:

  • Attributes. We're not generating the methods related to attributes yet (proposal in Remember attributes as bitflags #471)
  • Global variables. This is fixed in this PR and there's a slight caveat. I changed the fully qualified to be just the global variable name, but I kept the owner as Object. I believe this is fine for now, but we may want to revisit later. Global variables are accessible everywhere, so maybe for completion/go to definition algorithms, it will make more sense to place it in BasicObject? Or perhaps we need the magic <main>? I'll leave that to a dedicated PR

@vinistock vinistock self-assigned this Jan 19, 2026
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock marked this pull request as ready for review January 19, 2026 18:42
@vinistock vinistock requested a review from a team as a code owner January 19, 2026 18:42
@vinistock vinistock force-pushed the 01-19-correct_fully_qualified_global_variable_names branch from 0d03bc5 to 1821c5b Compare January 19, 2026 19:12
@vinistock vinistock enabled auto-merge (squash) January 19, 2026 19:13
@vinistock vinistock merged commit cbc4f0f into main Jan 19, 2026
26 checks passed
@vinistock vinistock deleted the 01-19-correct_fully_qualified_global_variable_names branch January 19, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement proper full names

2 participants