Skip to content

Improve review skill: suggest extracting repeated test setups into helpers #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 1 commit into from
Mar 2, 2026
Merged

Improve review skill: suggest extracting repeated test setups into helpers #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/review_changes/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Use the Rust and static analysis experts to review the code changes regarding th
- Code quality and idiomatic patterns: does the code use idiomatic Rust? Are there opportunities to improve the code
structure?
- Performance: are there any performance pitfalls or opportunities for optimization?
- Test coverage: are we missing scenarios?
- Test coverage: are we missing scenarios? Are there repeated test setups that could be extracted into a test helper?
- Documentation: are the key concepts clearly explained in the documentation (files under `docs` and README)?
- Agent instructions: are there key concepts or major changes that should be reflected in AGENTS.md?

Expand Down
Loading