Skip to content

Index method aliases with RBS indexer#631

Open
alexcrocha wants to merge 1 commit into03-05-add_receiver_to_methodaliasdefinitionfrom
03-03-index_method_aliases_with_rbs_indexer
Open

Index method aliases with RBS indexer#631
alexcrocha wants to merge 1 commit into03-05-add_receiver_to_methodaliasdefinitionfrom
03-03-index_method_aliases_with_rbs_indexer

Conversation

@alexcrocha
Copy link
Contributor

@alexcrocha alexcrocha commented Mar 4, 2026

One more step towards #87.

This PR adds visit_alias_node so method aliases in RBS files are indexed. Both instance aliases (alias bar baz) and singleton aliases (alias self.x self.y) are supported.

Copy link
Contributor Author

alexcrocha commented Mar 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from 02-27-index_includes_prepends_and_extends_with_rbs_indexer to main March 4, 2026 04:20
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from 7c6268e to 28dbeea Compare March 4, 2026 22:38
@alexcrocha alexcrocha marked this pull request as ready for review March 4, 2026 22:45
@alexcrocha alexcrocha requested a review from a team as a code owner March 4, 2026 22:45
@alexcrocha alexcrocha self-assigned this Mar 4, 2026
@alexcrocha alexcrocha changed the base branch from main to graphite-base/631 March 5, 2026 21:35
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from 28dbeea to 89bb5ce Compare March 5, 2026 21:35
@alexcrocha alexcrocha changed the base branch from graphite-base/631 to 03-05-add_receiver_to_methodaliasdefinition March 5, 2026 21:35
@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch from 9371724 to 97823c7 Compare March 6, 2026 03:37
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from 89bb5ce to fd6ae04 Compare March 6, 2026 03:37
@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch from 97823c7 to 1315d61 Compare March 6, 2026 04:01
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from fd6ae04 to 83ff3e8 Compare March 6, 2026 04:01
@alexcrocha alexcrocha requested a review from vinistock March 6, 2026 04:06
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch from 1315d61 to 9b94dda Compare March 6, 2026 16:49
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch 2 times, most recently from e21a565 to d7a675a Compare March 6, 2026 18:09
@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch 2 times, most recently from 0a6b50b to 5975a19 Compare March 6, 2026 18:15
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from d7a675a to 48da4ca Compare March 6, 2026 18:15
@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch from 5975a19 to a06d83c Compare March 6, 2026 22:05
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch 2 times, most recently from 035dd8c to 67f3b7a Compare March 7, 2026 04:52
Handle alias and alias self.x self.y declarations in RBS
files. Instance aliases use the enclosing class as owner, while
singleton aliases (self. prefix) use SelfReceiver to route
through the singleton class during resolution
@alexcrocha alexcrocha force-pushed the 03-05-add_receiver_to_methodaliasdefinition branch from e2e0984 to 3ef8701 Compare March 7, 2026 17:06
@alexcrocha alexcrocha force-pushed the 03-03-index_method_aliases_with_rbs_indexer branch from 67f3b7a to 351cfb5 Compare March 7, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants