Closed
Conversation
|
Closing as we are moving to the proper implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
Prototype PR to adds support for WebAuthn on the CLI. Changes to the client can be found here: Client PR: Shopify/rubygems#38
Resources:
CLI Flows: https://docs.google.com/document/d/1FlIfW-zmvLmflOvo7oOUuEleQBTodo-8lVJdiRcYySw/edit#heading=h.kjywlfxfaool
What approach did you choose and why?
This flow is similar to the first prototype #56. and functionality is built from this prototype.
The main addition is 84e8803 commit.
This creates an api endpoint for the client to poll the WebAuthn OTP code from once verification is completed (
api/v1/webauthn/:token/status). Currently, it returns a plain text response with the code or an error, however if this solution is chosen, I would consider a more robust response structure eg.On the client Shopify/rubygems#38, a thread is created when asking for OTP and it'll poll this endpoint for 5 mins, every
3 secondschanged it to 1 until a response returns.Demo
Screen.Recording.2022-11-30.at.5.53.33.AM.mov
Notes / Stuff I haven't explored