Skip to content

[POC] WebAuthn CLI #1#36

Draft
jenshenny wants to merge 1 commit intomasterfrom
webauthn-cli-1
Draft

[POC] WebAuthn CLI #1#36
jenshenny wants to merge 1 commit intomasterfrom
webauthn-cli-1

Conversation

@jenshenny
Copy link

@jenshenny jenshenny commented Nov 27, 2022

See Shopify/rubygems.org#56 for details

This PR requests a custom url from RubyGems.org when asking for OTP. If email/password is given (in the signin case), it'll use basic auth, otherwise it'll use api key auth.

Potential blockers / changes

I have to pass down email/password down multiple levels (rubygems_api_request, ask_otp, webauthn_verification_url). Probably need to structure that better if this solution is chosen.

@bettymakes
Copy link

bettymakes commented Dec 1, 2022

On your note of potential blockers / changes:
One minor step we can take is passing the email and password as a credentials hash instead. Although, we'd still need to pass it all the way down. I'll spend more time thinking on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants