Update firebase/php-jwt to ^7.0 (security fix)#456
Merged
Conversation
Resolves #454. The firebase/php-jwt ^5.2 || ^6.2 constraint is affected by security advisory GHSA-2x45-7fc3-mxwq (CVE-2025-45769), which prevents Composer from installing the library without warnings. - Update firebase/php-jwt constraint to ^7.0 - Regenerate composer.lock on PHP 8.1 to maintain compatibility - Update test secrets to meet v7 minimum HMAC key size (32 bytes) - Extract test secrets into named constants for readability - Fix broken packagist link in README Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lizkenyon
force-pushed
the
update-firebase-jwt
branch
from
b420cab to
4a144a8
Compare
|
Thank you for expediting this. Much appreciated 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firebase/php-jwtfrom^5.2 || ^6.2to^7.0to address security vulnerability GHSA-2x45-7fc3-mxwq (CVE-2025-45769, CVSS 7.3 — weak encryption)Context
firebase/php-jwt v7 enforces minimum key sizes for HMAC algorithms (32 bytes for HS256). Shopify API secrets are always >= 32 characters (legacy format: 32 hex chars, new format:
shpss_+ 32 chars = 38 chars), so no real users are affected by this enforcement. The test suite used short mock secrets ('steffi','rocky') which needed updating.Closes #454
Test plan
🤖 Generated with Claude Code