Skip to content

added ldap channel binding support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mr-pmillz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added ldap channel binding support #33

mr-pmillz wants to merge 1 commit into from

Conversation

@mr-pmillz
Copy link

@mr-pmillz mr-pmillz commented Apr 2, 2025

added ldap channel binding support.

Seems to work properly as expected. Cheers 🍻

@ShutdownRepo
Copy link
Owner

ShutdownRepo commented Apr 21, 2025

Hello there, thank you for your PR!
However, I'm having doubts. The lyak's ldap3 module seems to be 100+ commits behind the origin.
Oh and imo, the best would be to update setup.py and pyproject.toml with the lib change instead of printing a comment to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mr-pmillz @ShutdownRepo