Deck component #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaryanshroff
commented
Jul 13, 2023
aaryanshroff
commented
Jul 13, 2023
aaryanshroff
commented
Jul 13, 2023
aaryanshroff
commented
Jul 13, 2023
aaryanshroff
commented
Jul 13, 2023
aaryanshroff
commented
Jul 13, 2023
Member
Author
|
@ehuan2 Please approve, fixed. Thanks. |
Contributor
I shall work on integrating this first into what exists, and removing the new pages :) thanks for the amazing styles! |
ehuan2
approved these changes
Jul 26, 2023
Contributor
ehuan2
left a comment
ehuan2
left a comment
There was a problem hiding this comment.
Looks good to me! As a note: still not exactly what we want just yet (haven't fixed up the backend to match) but this will be a great start to add in the stylings!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the branch name
Examples:
Please see https://github.com/Sign-Language-SRS/frontend/pull/2/files#diff-7b9770f869d42f9690f8caf16b66a02244e19cbc628cb771368e4e2f6faedf2eR8 for all possible props to this component.
Circular progress bar is automatically calculated based on # of completed cards and # of total cards.
We can replace the icon with a Japanese alphabet or word? (I don't know how long they are).