-
Notifications
You must be signed in to change notification settings - Fork 30
[SL-ONLY] Feature/rangehood app #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp
Outdated
Show resolved
Hide resolved
bb74b3b to
4e4e746
Compare
4e4e746 to
993bfda
Compare
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
arun-silabs
reviewed
Nov 10, 2025
arun-silabs
reviewed
Nov 10, 2025
arun-silabs
reviewed
Nov 10, 2025
arun-silabs
reviewed
Nov 10, 2025
arun-silabs
reviewed
Nov 10, 2025
arun-silabs
reviewed
Nov 10, 2025
examples/rangehood-app/rangehood-app-common/include/LightEndpoint.h
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
Contributor
sabollim-silabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nit picks
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
sabollim-silabs
approved these changes
Nov 19, 2025
Contributor
sabollim-silabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving with few nits
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
…ndpoint.cpp Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Outdated
Show resolved
Hide resolved
examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sl-only
This TAG indicates that this commit is a silabs-specific commit that cannot be upstreamed to CSA.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new Matter Rangehood example implementing composite device type of Fan and Light.
Summary of Updates:
Implemented multi-endpoint architecture:
Root Node Endpoint (ID: 0)
Fan Endpoint (ID: 1)
Light Endpoint(ID: 2)
Added Fan control and Light On/Off control. Added button implementation to control fan on/off.
Also added LED mapping to display current state of the light.
Related issues
MATTER-5148
Testing
Verified commissioning and basic functionality on SiWx917 evaluation board.
Validated fan control via cluster commands as well as on BTN1 Press.
Validated lighting on/off via cluster commands
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines
Note
Introduces a Silabs Matter rangehood example app with multi-endpoint Fan and Light control, button/LED handling, and corresponding GN/ZAP data model and build configs.
rangehood-appwith endpoints: root (0), extractor hood fan (1,FanControl), light (2,OnOff).ExtractorHoodEndpoint,LightEndpoint, andRangeHoodManagerwith attribute-change handling and state sync.AppTaskwiring: buttonBTN1toggles fan Off/High; LED reflects light on/off; event dispatch viaDataModelCallbacks.rangehood-wifi-app.zap/.matter) defining clusters and attributes for all endpoints..gn,BUILD.gn, data_modelBUILD.gn) and Wi‑Fi args; enables OTA Requestor for SiWx917.CHIPProjectConfig.h,AppConfig.h) and third-party CHIP link.Written by Cursor Bugbot for commit 51117f0. This will update automatically on new commits. Configure here.