Fix named function arguments conflicts #8350
Open
+220
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
added
bug
Efnilite
requested review from
cheeezburga and
erenkarakal
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
UnderscoreTud
requested changes
Jan 5, 2026
src/main/java/org/skriptlang/skript/common/function/FunctionReferenceParser.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Jan 5, 2026
...skript/tests/regressions/8350-fully qualified names and named function arguments conflict.sk
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Jan 6, 2026
1 task
Efnilite
changed the title
APickledWalrus
requested changes
Jan 6, 2026
src/test/skript/tests/regressions/8350-named function arguments conflicts.sk
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/common/function/FunctionArgumentParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/common/function/FunctionReference.java
Outdated
Show resolved
Hide resolved
skriptlang-automation
bot
removed
the
needs reviews
…fa' into feature/fix-full-qualifiers-in-nfa
APickledWalrus
approved these changes
Jan 8, 2026
skriptlang-automation
bot
added
the
feature-ready
sovdeeth
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Problem 1
Passing
minecraft:plainsto a function would result in the function incorrectly assuming a signature containing a named function parameter calledminecraftexists.Problem 2
Strings in expressions in strings are not properly handled, e.g.
"%now formatted as "HH:mm:ss"%".Solution
Problem 1
If a parameter is found to be null with a non-null argument value, attempts to parse
name:value. Some additional reformatting has been added to this PR.Problem 2
Add additional parsing logic to FunctionArgumentParser.
Testing Completed
Supporting Information
Completes: #8342
Related: none
AI assistance: none