Skip to content

timeout signature for fsockopen is float#10

Merged
drwho725 merged 1 commit intoSlickdeals:masterfrom
sveneld:timeout
Feb 9, 2026
Merged

timeout signature for fsockopen is float#10
drwho725 merged 1 commit intoSlickdeals:masterfrom
sveneld:timeout

Conversation

@sveneld
Copy link
Copy Markdown

@sveneld sveneld commented Mar 19, 2024

No description provided.

@sveneld
Copy link
Copy Markdown
Author

sveneld commented Mar 25, 2024

@bfeaver take a look

@bfeaver
Copy link
Copy Markdown
Member

bfeaver commented Mar 26, 2024

This looks to me like an ok change to make based on briefly reviewing it. I'll take a look at it later in more detail and should be able to get back to you soon.

@sveneld
Copy link
Copy Markdown
Author

sveneld commented Jul 10, 2024

@bfeaver any news?

@drwho725
Copy link
Copy Markdown

@sveneld are you able to make your commit have verified signature?

image

@sveneld
Copy link
Copy Markdown
Author

sveneld commented Apr 24, 2025

Is this strictly necessary?

@sveneld
Copy link
Copy Markdown
Author

sveneld commented Feb 8, 2026

@drwho725 i have signed my commit

@drwho725 drwho725 merged commit 2863a82 into Slickdeals:master Feb 9, 2026
5 checks passed
@drwho725
Copy link
Copy Markdown

drwho725 commented Feb 9, 2026

@sveneld https://github.com/Slickdeals/statsd-php/releases/tag/3.2.3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants