Conversation
- Change timeout parameter from int to float in test constructors
- Replace assertEquals with assertSame for strict type checking
- Add explicit float cast for ini_get('default_socket_timeout')
- Convert bare URL to markdown link - Update version constraint to ^3.2 - Fix grammar and typos (therefor, options) - Add Connection Timeout section with float examples - Standardize heading capitalization
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Type
Tests, Documentation
Description
Update socket timeout assertions to use float type for strict validation
Replace assertEquals with assertSame for timeout type checking
Add explicit float cast for ini_get('default_socket_timeout') calls
Add Connection Timeout section with float examples and documentation
Fix grammar, typos, and improve README accuracy
Update version constraint from ~3.0 to ^3.2
Diagram Walkthrough
File Walkthrough
TcpSocketTest.php
Update TCP socket timeout tests to float typetests/unit/Connection/TcpSocketTest.php
constructors
on timeout assertions
comparison
UdpSocketTest.php
Update UDP socket timeout tests to float typetests/unit/Connection/UdpSocketTest.php
constructors
on timeout assertions
comparison
README.md
Add timeout documentation and improve README accuracyREADME.md
repository
and TcpSocket
structure
"Disabling Sending of Metrics"