WWSTCERT-8745 Add support to frient vibration sensor wiszb 137 #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibration-sensor-WISZB-137
…tps://github.com/marcintyminski/SmartThingsEdgeDrivers into Add-support-to-frient-vibration-sensor-WISZB-137
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ac43af1 |
greens
changed the title
greens
reviewed
Nov 11, 2025
| if attribute_id == 0x0000 then | ||
| measured_x = axis_value | ||
| device:set_field("measured_x", measured_x) | ||
| log.trace("Updated X value: " .. axis_value) |
Contributor
There was a problem hiding this comment.
if you're satisfied with the behavior, please remove the logging
greens
reviewed
Nov 11, 2025
| ID = 0xFC04, | ||
| ManufacturerSpecificCode = 0x1015, | ||
| attributes = { | ||
| MeasuredValueX = { ID = 0x0000, data_type = data_types.name_to_id_map["Int16"] }, |
Contributor
There was a problem hiding this comment.
you can just use data_types.Int16
greens
reviewed
Nov 11, 2025
Comment on lines
+164
to
+169
| log.trace "Initializing sensor" | ||
| battery_defaults.build_linear_voltage_init(2.3, 3.0)(driver, device) | ||
| --Add the manufacturer-specific attributes to generate their configure reporting and bind requests | ||
| for _, config in pairs(get_cluster_configurations()) do | ||
| device:add_configured_attribute(config) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests