Return None for nullable CountryField when value is NULL #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CountryField has null=True and the database value is NULL, the descriptor now returns None instead of Country(code=None). This moves nullability from Country.code (str | None) to the field access itself (Country | None), resulting in cleaner typing and consistent behavior with nullable multiple fields. Fixes #481
This was referenced Dec 18, 2025
When a nullable CountryField returns None (instead of Country(code=None)), the serializer should handle it explicitly rather than relying on alpha2() converting 'None' string to empty string.
Verify that nullable CountryField works correctly with GraphQL: - Returns full Country type when value is present - Returns null when database value is NULL
Test the full round-trip: save NULL to database, fetch it back, and serialize. This verifies the descriptor correctly returns None and the serializer handles it properly.
Add documentation explaining that nullable CountryField now returns None instead of Country(code=None), with examples and migration guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CountryField(withnull=True) now returnsNoneinstead ofCountry(code=None)when the database value is NULLCountry.codeis alwaysstr(neverNone)Breaking change
Code that previously checked
obj.country.code is Noneshould now checkobj.country is None. The common patternif obj.country:continues to work unchanged.Fixes #481
Test plan