Feature1 #1
Open
Feature1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhh139
suggested changes
Mar 2, 2024
| class ApplicationController < ActionController::API | ||
| end | ||
| before_action :authorized | ||
|
|
There was a problem hiding this comment.
@Smokashi23 Please fix spacing and indentation
| begin | ||
| JWT.decode(token, Rails.application.credentials[:secret_key_base] ) | ||
| rescue JWT::DecodeError | ||
| nil |
There was a problem hiding this comment.
@Smokashi23 Do not return nil from this function, instead return some error message i.e. 'Unable to decode token'
| def authorized | ||
| @user = User.find_by!(email: user_params[:email]) | ||
| if current_user.nil? | ||
| render json: { message: 'Please log in' }, status: :unauthorized |
There was a problem hiding this comment.
Use I18n.t for displaying any message
| token: @token | ||
| }, status: :accepted | ||
| else | ||
| render json: {message: 'Incorrect password'}, status: :unauthorized |
There was a problem hiding this comment.
Please use I18 for displaying message
| end | ||
|
|
||
| def handle_record_not_found(e) | ||
| render json: { message: "User doesn't exist" }, status: :unauthorized |
There was a problem hiding this comment.
Suggested change
| render json: { message: "User doesn't exist" }, status: :unauthorized | |
| render json: { message: I18n.t(''message') }, status: :unauthorized |
| end | ||
|
|
||
| end | ||
|
|
| @@ -0,0 +1,15 @@ | |||
| class User < ApplicationRecord | |||
| validates :email, presence: true, uniqueness: { message: " already exist" }, format: { with: /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i , message: "Invalid"} | |||
There was a problem hiding this comment.
message should be displayed through I18n only
| require "test_helper" | ||
|
|
||
| class AuthsControllerTest < ActionDispatch::IntegrationTest | ||
| # test "the truth" do |
There was a problem hiding this comment.
@Smokashi23 Please do not commit unnecessary files
| @@ -0,0 +1,11 @@ | |||
| # Read about fixtures at https://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html | |||
|
|
|||
| # This model initially had no columns defined. If you add columns to the | |||
There was a problem hiding this comment.
Please do not commit unnecessary files
|
|
||
| class UsersControllerTest < ActionDispatch::IntegrationTest | ||
| # test "the truth" do | ||
| # assert true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.