Skip to content

Conversation

@razor-x
Copy link

@razor-x razor-x commented Apr 8, 2025

@dexter93 I tired to get your PR working, but I kept getting errors due to the string passing / quoting issues.

I made a few changes and tested this version which is working. Feel free to incorporate these changes into you PR, or we can just try to get this one merged. Either is ok by me.

I am able to pass ldflags now like this which is a bit nicer UX for multiple flags.

    - name: Wails build
      uses: rxfork/wails-build-action@f8b90a113b5f744d191c845a09040632e8821a11
      with:
        build: true
        build-ldflags: >-
          -X=main.AppVersion=${{ steps.meta.outputs.version }}
          -X=main.Foo=${{ inputs.foo }}

Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a better version indeed. Let's do this

@qverkk
Copy link

qverkk commented Jun 23, 2025

@Snider any ETA on getting this merged? 😄 i'd love to use ldflags to set the binary version dynamically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants