-
Notifications
You must be signed in to change notification settings - Fork 1.2k
init mediawallah-enrichment-app #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init mediawallah-enrichment-app #1849
Conversation
|
Hi Jeff - the architecture looks great! For the quickstart, why were the package.json and package-lock.json files deleted? Once I recreated the package.json file - it was not a problem. Flagging this to @iamontheinet in case it will cause an issue during merge. Overall, I think our team now requires notebooks for these code blocks that are in the quickstart; however, the quickstart looks pretty good. Some notes and edits requested on the quickstart:
Suggested formatting for first page: |
|
Don't delete package.json and/or package-lock.json. Just don't include them in your PR. |
…ter package.json and package-lock.json
|
Hey Luke, thanks for giving it a once over.
please note that this is still using the 1.3 Framework. please let me know if you have any questions, and if there is anything else you would like addressed. Thank you. |
|
Ok @iamontheinet - this one is good to go! |
|
We also have the code in a sf-samples based on the requirements we received. But there hasn't been any movement there. |
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
...-mediawallah-enrichment-native-app/getting-started-with-mediawallah-enrichment-native-app.md
Outdated
Show resolved
Hide resolved
… update to Published
|
@sfc-gh-lambrosetti @iamontheinet |
MediaWallah accepts the CLA posted in the Readme.
This is our Quickstarts Draft. We will be populating links such as sf-samples, youtube, and Blog as soon as those are approved in future PRs.